1 Star 0 Fork 0

耿嘉祺 / PubSubJS

Create your Gitee Account
Explore and code with more than 6 million developers,Free private repositories !:)
Sign up
Clone or download
Copy Edit Web IDE Raw Blame History
Sergey Sokurenko authored 2019-08-04 11:44 . Added PubSubJS logo

Contributing to PubSubJS

We love pull requests. Here's a quick guide:

  1. Fork the repo.

  2. Run the tests. We only take pull requests with passing tests, and it's great to know that you have a clean slate

  3. Add a test for your change. Only refactoring and documentation changes require no new tests. If you are adding functionality or fixing a bug, we need a test!

  4. Make the test pass.

  5. Push to your fork and submit a pull request.

At this point you're waiting on us. We like to at least comment on, if not accept, pull requests within three business days (and, typically, one business day). We may suggest some changes or improvements or alternatives.

  • Use JavaScript idioms
  • Include tests that fail without your code, and pass with it
  • Update the documentation, the surrounding one, examples elsewhere, guides, whatever is affected by your contribution

And in case we didn't emphasize it enough: we love tests!


Install Editor Config for your text editor, this will ensure that the correct formatting is applied for each file type.

Comment ( 0 )

Sign in for post a comment