48 Star 362 Fork 82

GVP第四范式 / OpenMLDB

 / 详情

style: update hybridse header guard style

已完成
成员
创建于  
2021-09-02 12:15

Please send PR to our GitHub repo https://github.com/4paradigm/OpenMLDB

Is your feature request related to a problem? Please describe.

hybridse source moved, cpplint reports header guards problem.
so we add -build/header_guard filter to cpplint temporarily

Describe the solution you'd like

  • update header guard in hybridse cpp file, add HYBRIDSE_ prefix
  • rm -build/header_guard in workflow file: style.yml

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

评论 (4)

铜须 创建了任务
铜须 关联仓库设置为第四范式/OpenMLDB
铜须 修改了描述
铜须 修改了标题
铜须 修改了描述
展开全部操作日志

should we update all cpp file included in dir /hybridse?

as long as cpplint $file not report any error in /hybridse

Notice: comment out the second line of hybridse/CPPLINT.cfg before running cpplint

linelength=120
# filter=-build/header_guard

or the header guard check will skipped

thank you for replying:)
since PR need to be tested in github workflow, is there any need to send a same PR in gitee?
and it seems that the gitee repo is just a read-only copy from github.

since the PR in gitee is just for completing awarwed task, i just reuse the older pull request.
the PR in github is pull request

铜须 任务状态待办的 修改为已完成

登录 后才可以发表评论

状态
负责人
里程碑
Pull Requests
关联的 Pull Requests 被合并后可能会关闭此 issue
分支
开始日期   -   截止日期
-
置顶选项
优先级
参与者(2)
9583135 aceforeverd 1630568946
C++
1
https://gitee.com/paradigm4/OpenMLDB.git
git@gitee.com:paradigm4/OpenMLDB.git
paradigm4
OpenMLDB
OpenMLDB

搜索帮助

14c37bed 8189591 565d56ea 8189591