Please send PR to our GitHub repo https://github.com/4paradigm/OpenMLDB
Is your feature request related to a problem? Please describe.
hybridse source moved, cpplint reports header guards problem.
so we add -build/header_guard
filter to cpplint temporarily
Describe the solution you'd like
HYBRIDSE_
prefix-build/header_guard
in workflow file: style.yml
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
should we update all cpp file included in dir /hybridse?
as long as cpplint $file
not report any error in /hybridse
Notice: comment out the second line of hybridse/CPPLINT.cfg
before running cpplint
linelength=120
# filter=-build/header_guard
or the header guard check will skipped
thank you for replying:)
since PR need to be tested in github workflow, is there any need to send a same PR in gitee?
and it seems that the gitee repo is just a read-only copy from github.
此处可能存在不合适展示的内容,页面不予展示。您可通过相关编辑功能自查并修改。
如您确认内容无涉及 不当用语 / 纯广告导流 / 暴力 / 低俗色情 / 侵权 / 盗版 / 虚假 / 无价值内容或违法国家有关法律法规的内容,可点击提交进行申诉,我们将尽快为您处理。
since the PR in gitee is just for completing awarwed task, i just reuse the older pull request.
the PR in github is pull request
登录 后才可以发表评论