Thanks for your interest in contributing to the project! Please follow these simple guidelines:
GitHub
project is a must. It's quite likely your question has already been answered before. If something is unclear in the FAQ, of course feel free to ask; the idea is just to reduce the level of "noise" we have to go through, reading the same questions over and over again.CefSharp
to see whether the problem you are encountering still exists.GitHub
account can edit the WIKI
)CefSharp
vs Chromium Embedded Framework(CEF)
CefSharp
simply takes the building blocks provided by CEF
and attempts to provide a usable '.Net' implementation.
The upstream CEF
forum is a valuable resource, if your issues seems fairly low level, then please conduct some research before posting.
It maybe helpful to run the cefclient
application and compare output with CefSharp
. The WinForms
and WPF
versions use two different rendering modes, WPF
uses Offscreen Rendering (OSR
). OffScreen
also uses OSR
mode.
cefclient.exe --multi-threaded-message-loop --off-screen-rendering-enabled --enable-gpu --no-sandbox --disable-site-isolation-trials
cefclient.exe --multi-threaded-message-loop --no-sandbox --disable-site-isolation-trials
cefclient
then you'll need to report the bug on https://bitbucket.org/chromiumembedded/cef/overview there is no point opening an issue here. (Make sure you search before opening an issue)Issue
?When creating an issue please use the provided by report template (the field will be pre-populated).
A bug is a demonstrable problem that is caused by the code in the repository. Ideally each issue is a useful resource for references purposes (Don't take offence if someone edits your description).
Your bug report should always follow this template:
WinForms
, WPF
or OffScreen
?CEF Sample Application
from http://opensource.spotify.com/cefbuilds/index.html?Your bug report should include what you were doing in the software when you encountered it, what you were expecting to happen and what happened instead.
BE AWARE THAT BUG REPORTS MUST PROVIDE ALL OF THE INFORMATION STATED ABOVE!
Change requests cover both architectural and functional changes to how CefSharp
works. If you have an idea for a refactor, or an improvement to a feature, etc - please be sure to:
Pull requests are awesome. If you're looking to raise a PR
for something which doesn't have an open issue, please think carefully about raising an issue which your PR can close, especially if you're fixing a bug. This makes it more likely that there will be enough information available for your PR to be properly tested and merged.
Please limit your changes to a logical grouping, keeping changesets small increases the likelihood they will be merged
If you then want to make subsequent changes, it's actually best to not do them before the feature is merged. Please wait for feedback/review before progressing. This greatly improves our ability to review your changes and dramatically increases the likelihood they will be merged in a timely fashion.
If you wish to keep progressing on your work, please maintain a feature branch independent of the branch referenced by your pull request. From your WIP branch you can selectively merge in changes to the PR branch as required.
In general, it's much better to be "too granular" with PR's that contain "change-the-world"-kind of changes, which usually tend to lag behind a lot longer before getting merged (if they ever will...).
Small (really, minimalistic) commits. Each individual commit only adds one specific thing. The basic approach to achieving this is to read your commit message. Do you feel the need to add multiple lines? Then you're doing too much at the same time.
Keep the first line of commit message short (max 50 characters), then a blank line, then a full description if needed. Good example:
Run tests in the default appdomain
Due to limitations of VC++ we must run our tests in the default appdomain, it's possible to use xunit for testing. Re-add CefSharp.Test.csproj to solution Add some very basic unit tests using xunit, DisableTestParallelization, Set xunit.appDomain to denied in app.config to disable using appdomains (https://xunit.github.io/docs/configuring-with-xml.html) Add xunit vs test running packages, using 2.2.0 version as 2.3.0 was throwing an exception similar to https://github.com/xunit/xunit/issues/1514 TODO: Take a look at https://github.com/NuGet/NuGetGallery/tree/master/tests/NuGetGallery.Facts for some ideas on structuring xunit tests (look at implementing Theory)
此处可能存在不合适展示的内容,页面不予展示。您可通过相关编辑功能自查并修改。
如您确认内容无涉及 不当用语 / 纯广告导流 / 暴力 / 低俗色情 / 侵权 / 盗版 / 虚假 / 无价值内容或违法国家有关法律法规的内容,可点击提交进行申诉,我们将尽快为您处理。