2.4K Star 8.2K Fork 4.4K

GVPMindSpore / mindspore

 / 详情

(Possibly) excessive conversion of dataset items

REJECTED
Bug-Report
创建于  
2024-04-22 18:46
name about labels
Bug Report Use this template for reporting a bug kind/bug

Describe the current behavior / 问题描述 (Mandatory / 必填)

Dataset row processing _convert_row method (mindspore/python/mindspore/dataset/engine/datasets_user_defined.py) possibly issuing excessive conversion of items to np.array if the object is already of type np.ndarray.

Environment / 环境信息 (Mandatory / 必填)

  • Hardware Environment(Ascend/GPU/CPU) / 硬件环境: CPU

  • Software Environment / 软件环境 (Mandatory / 必填):
    -- MindSpore version (e.g., 1.7.0.Bxxx) : 2.2.1 (from related tag)
    -- Python version (e.g., Python 3.7.5) : CPython 3.9.18
    -- OS platform and distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 20.04
    -- GCC/Compiler version (if compiled from source): GCC 9.4.0

  • Excute Mode / 执行模式 (Mandatory / 必填)(PyNative/Graph): N/A

Related testcase / 关联用例 (Mandatory / 必填)

N/A

Steps to reproduce the issue / 重现步骤 (Mandatory / 必填)

N/A (code does not lead to any execution issues)

Describe the expected behavior / 预期结果 (Mandatory / 必填)

Items of type np.ndarray should be directly added to the result value.

Related log / screenshot / 日志 / 截图 (Mandatory / 必填)

N/A

Special notes for this issue/备注 (Optional / 选填)

It seems for us that np.ndarray row/row items can be directly added to the result value instead of calling np.array(x, copy=False), because np.array() NumPy method is designed to create the same np.ndarray object.

We assume this change can result in minor performance improvement in processing dataset rows.

For the demonstration of improvement, take a look at the commit in our fork: https://gitee.com/GerasimovAlexander/mindspore/commit/e97457b0435691ed50bb85236a9f50c460546646

评论 (3)

Alexander 创建了Bug-Report

Please assign maintainer to check this issue.
请为此issue分配处理人。
@fangwenyi @chengxiaoli @Shawny

感谢您的提问,您可以评论//mindspore-assistant更快获取帮助:

  1. 如果您刚刚接触MindSpore,或许您可以在教程找到答案
  2. 如果您是资深Pytorch用户,您或许需要:
  1. 如果您遇到动态图问题,可以设置set_context(pynative_synchronize=True)查看报错栈协助定位
  2. 模型精度调优问题可参考官网调优指南
  3. 如果您反馈的是框架BUG,请确认您在ISSUE中提供了MindSpore版本、使用的后端类型(CPU、GPU、Ascend)、环境、训练的代码官方链接以及可以复现报错的代码的启动方式等必要的定位信息
  4. 如果您已经定位出问题根因,欢迎提交PR参与MindSpore开源社区,我们会尽快review
Shawny 任务状态TODO 修改为REJECTED

登录 后才可以发表评论

状态
负责人
项目
里程碑
Pull Requests
关联的 Pull Requests 被合并后可能会关闭此 issue
分支
开始日期   -   截止日期
-
置顶选项
优先级
预计工期 (小时)
参与者(2)
Python
1
https://gitee.com/mindspore/mindspore.git
git@gitee.com:mindspore/mindspore.git
mindspore
mindspore
mindspore

搜索帮助